* [PATCH 2/4] staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups
@ 2011-01-02 22:14 Javier Martinez Canillas
2011-01-03 16:11 ` [PATCH 2/4] staging: keucr: Use memcpy() instead custom Marcin Slusarz
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2011-01-02 22:14 UTC (permalink / raw)
To: kernel-janitors
staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
drivers/staging/keucr/smilecc.c | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/keucr/smilecc.c b/drivers/staging/keucr/smilecc.c
index daf322a..5659dea 100644
--- a/drivers/staging/keucr/smilecc.c
+++ b/drivers/staging/keucr/smilecc.c
@@ -182,13 +182,17 @@ BYTE *buf;
BYTE *redundant_ecc;
BYTE *calculate_ecc;
{
- DWORD err;
+ DWORD err;
- err=correct_data(buf,redundant_ecc,*(calculate_ecc+1),*(calculate_ecc),*(calculate_ecc+2));
- if (err=1) StringCopy(calculate_ecc,redundant_ecc,3);
- if (err=0 || err=1 || err=2)
- return(0);
- return(-1);
+ err = correct_data(buf, redundant_ecc, *(calculate_ecc + 1),
+ *(calculate_ecc), *(calculate_ecc + 2));
+ if (err = 1)
+ memcpy(calculate_ecc, redundant_ecc, 3);
+
+ if (err = 0 || err = 1 || err = 2)
+ return 0;
+
+ return -1;
}
void _Calculate_D_SwECC(buf,ecc)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/4] staging: keucr: Use memcpy() instead custom
2011-01-02 22:14 [PATCH 2/4] staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups Javier Martinez Canillas
@ 2011-01-03 16:11 ` Marcin Slusarz
0 siblings, 0 replies; 2+ messages in thread
From: Marcin Slusarz @ 2011-01-03 16:11 UTC (permalink / raw)
To: kernel-janitors
On Sun, Jan 02, 2011 at 11:14:27PM +0100, Javier Martinez Canillas wrote:
> staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
> drivers/staging/keucr/smilecc.c | 16 ++++++++++------
> 1 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/keucr/smilecc.c b/drivers/staging/keucr/smilecc.c
> index daf322a..5659dea 100644
> --- a/drivers/staging/keucr/smilecc.c
> +++ b/drivers/staging/keucr/smilecc.c
> @@ -182,13 +182,17 @@ BYTE *buf;
> BYTE *redundant_ecc;
> BYTE *calculate_ecc;
> {
> - DWORD err;
> + DWORD err;
>
> - err=correct_data(buf,redundant_ecc,*(calculate_ecc+1),*(calculate_ecc),*(calculate_ecc+2));
> - if (err=1) StringCopy(calculate_ecc,redundant_ecc,3);
> - if (err=0 || err=1 || err=2)
> - return(0);
> - return(-1);
> + err = correct_data(buf, redundant_ecc, *(calculate_ecc + 1),
> + *(calculate_ecc), *(calculate_ecc + 2));
> + if (err = 1)
> + memcpy(calculate_ecc, redundant_ecc, 3);
> +
> + if (err = 0 || err = 1 || err = 2)
> + return 0;
> +
> + return -1;
> }
>
> void _Calculate_D_SwECC(buf,ecc)
> --
Now it looks good.
Reviewed-by: Marcin Slusarz <marcin.slusarz@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-03 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-02 22:14 [PATCH 2/4] staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups Javier Martinez Canillas
2011-01-03 16:11 ` [PATCH 2/4] staging: keucr: Use memcpy() instead custom Marcin Slusarz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox