From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Date: Thu, 06 Jan 2011 15:44:13 +0000 Subject: Re: [PATCH] ext3: Remove redundant unlikely() Message-Id: <20110106154413.GN4641@quack.suse.cz> List-Id: References: <1291905574-32355-1-git-send-email-tklauser@distanz.ch> In-Reply-To: <1291905574-32355-1-git-send-email-tklauser@distanz.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tobias Klauser Cc: Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu 09-12-10 15:39:34, Tobias Klauser wrote: > IS_ERR() already implies unlikely(), so it can be omitted here. Thanks. Merged. Honza > > Signed-off-by: Tobias Klauser > --- > fs/ext3/namei.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c > index bce9dce..268f776 100644 > --- a/fs/ext3/namei.c > +++ b/fs/ext3/namei.c > @@ -1047,7 +1047,7 @@ static struct dentry *ext3_lookup(struct inode * dir, struct dentry *dentry, str > return ERR_PTR(-EIO); > } > inode = ext3_iget(dir->i_sb, ino); > - if (unlikely(IS_ERR(inode))) { > + if (IS_ERR(inode)) { > if (PTR_ERR(inode) = -ESTALE) { > ext3_error(dir->i_sb, __func__, > "deleted inode referenced: %lu", > -- > 1.7.0.4 > -- Jan Kara SUSE Labs, CR