From: Alexey Dobriyan <adobriyan@gmail.com>
To: Dan Carpenter <error27@gmail.com>,
Dave Airlie <airlied@redhat.com>, Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] vga_switcheroo: comparing too few characters in
Date: Fri, 07 Jan 2011 05:30:54 +0000 [thread overview]
Message-ID: <20110107053054.GA9057@p183.telecom.by> (raw)
In-Reply-To: <20110107051227.GD1717@bicker>
On Fri, Jan 07, 2011 at 08:12:27AM +0300, Dan Carpenter wrote:
> This is a copy-and-paste bug. We should be comparing 4 characters here
> instead of 3.
> --- a/drivers/gpu/vga/vga_switcheroo.c
> +++ b/drivers/gpu/vga/vga_switcheroo.c
> @@ -346,11 +346,11 @@ vga_switcheroo_debugfs_write(struct file *filp, const char __user *ubuf,
> if (strncmp(usercmd, "DIS", 3) = 0)
> client_id = VGA_SWITCHEROO_DIS;
>
> - if (strncmp(usercmd, "MIGD", 3) = 0) {
> + if (strncmp(usercmd, "MIGD", 4) = 0) {
> just_mux = true;
> client_id = VGA_SWITCHEROO_IGD;
> }
> - if (strncmp(usercmd, "MDIS", 3) = 0) {
> + if (strncmp(usercmd, "MDIS", 4) = 0) {
How about you NUL-terminate, and use strcmp().
next prev parent reply other threads:[~2011-01-07 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 5:12 [patch] vga_switcheroo: comparing too few characters in strncmp() Dan Carpenter
2011-01-07 5:30 ` Alexey Dobriyan [this message]
2011-01-07 6:05 ` [patch] vga_switcheroo: comparing too few characters in Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107053054.GA9057@p183.telecom.by \
--to=adobriyan@gmail.com \
--cc=airlied@redhat.com \
--cc=error27@gmail.com \
--cc=jslaby@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox