Re: [patch v2] phonet: some signedness bugs

2011-01-10T14:12:03Z

On Monday 10 January 2011 16:06:58 ext Dan Carpenter, you wrote:
> Dan Rosenberg pointed out that there were some signed comparison bugs
> in the phonet protocol.
>
> http://marc.info/?l=full-disclosure&m\x129424528425330&w=2
>
> The problem is that we check for array overflows but "protocol" is
> signed and we don't check for array underflows. If you have already
> have CAP_SYS_ADMIN then you could use the bugs to get root, or someone
> could cause an oops by mistake.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Acked-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

--
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki