From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Removes warning related to use of uninitialized
Date: Thu, 13 Jan 2011 05:22:30 +0000 [thread overview]
Message-ID: <20110113052230.GJ2721@bicker> (raw)
In-Reply-To: <AANLkTi=h20J0XhFp2=iGH0WF-uZmWS0cv4018X=h5YBn@mail.gmail.com>
On Wed, Jan 12, 2011 at 06:26:43PM -0800, Sukanto Ghosh wrote:
> Diff against 2.6.37
>
Please specify which version of gcc you are using in your change log.
>
> Signed-off-by: Sukanto Ghosh <sukanto.cse.iitb@gmail.com>
>
> ----
> diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
> index b25e6e4..add97dd 100644
> --- a/drivers/serial/8250.c
> +++ b/drivers/serial/8250.c
> @@ -1724,7 +1724,7 @@ static int serial_link_irq_chain(struct
> uart_8250_port *up)
>
> static void serial_unlink_irq_chain(struct uart_8250_port *up)
> {
> - struct irq_info *i;
> + struct irq_info *i = NULL;
Use the uninitialized_var() macro instead of initializing it to NULL.
> struct hlist_node *n;
> struct hlist_head *h;
>
> @@ -1739,7 +1739,7 @@ static void serial_unlink_irq_chain(struct
> uart_8250_port *up)
> }
>
> BUG_ON(n = NULL);
> - BUG_ON(i->head = NULL);
> + BUG_ON(i = NULL || i->head = NULL);
This change won't work with the uninitialized_var() macro and is not
needed anyway (your changelog says that we're only doing this to silence
a warning).
regards,
dan carpenter
>
> if (list_empty(i->head))
> free_irq(up->port.irq, i);
next prev parent reply other threads:[~2011-01-13 5:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 2:26 [PATCH] Removes warning related to use of uninitialized variable i Sukanto Ghosh
2011-01-13 3:05 ` [PATCH] Removes warning related to use of uninitialized Greg KH
2011-01-13 4:05 ` [PATCH] Removes warning related to use of uninitialized variable i Sukanto Ghosh
2011-01-13 5:22 ` Dan Carpenter [this message]
2011-01-13 6:49 ` Sukanto Ghosh
2011-01-13 8:21 ` [PATCH] Removes warning related to use of uninitialized variable walter harms
2011-01-13 18:29 ` [PATCH] Removes warning related to use of uninitialized Greg KH
2011-01-13 19:38 ` [PATCH] Removes warning related to use of uninitialized variable i Sukanto Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113052230.GJ2721@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox