Re: [patch] 9p: fix min_t() casting

Dan Carpenter
2011-01-16T11:45:26Z

On Sat, Jan 15, 2011 at 08:52:08PM -0800, David Miller wrote:
> From: Dan Carpenter <error27@gmail.com>
> Date: Sat, 15 Jan 2011 23:35:39 +0300
>
> > The intent here was to cap the length to USHRT_MAX, but what the
> > code actually does is it just casts the return from strlen() to
> > unsigned short and truncates the significant bits away.
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> If you want me to apply this, it doesn't apply cleanly to net-2.6
> at all.

Sorry. I screwed up.

This was on top of a patch from M. Mohan Kumar <mohan@in.ibm.com>
that hasn't hit net-2.6 yet. Mohan wasn't included on the CC
list because get_maintainer.pl changed and I didn't notice and
I wasn't careful.

Eric, could Mohan just fix his patch before it gets merged or is it
better to send these as two patches?

regards,
dan carpenter

Ps: Mohon the patch is here: