From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Sun, 16 Jan 2011 11:45:26 +0000 Subject: Re: [patch] 9p: fix min_t() casting Message-Id: <20110116114526.GG2721@bicker> List-Id: References: <20110115203539.GF2721@bicker> <20110115.205208.104051310.davem@davemloft.net> In-Reply-To: <20110115.205208.104051310.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: ericvh@gmail.com, sripathik@in.ibm.com, jvrao@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, mohan@in.ibm.com On Sat, Jan 15, 2011 at 08:52:08PM -0800, David Miller wrote: > From: Dan Carpenter > Date: Sat, 15 Jan 2011 23:35:39 +0300 > > > The intent here was to cap the length to USHRT_MAX, but what the > > code actually does is it just casts the return from strlen() to > > unsigned short and truncates the significant bits away. > > > > Signed-off-by: Dan Carpenter > > If you want me to apply this, it doesn't apply cleanly to net-2.6 > at all. Sorry. I screwed up. This was on top of a patch from M. Mohan Kumar that hasn't hit net-2.6 yet. Mohan wasn't included on the CC list because get_maintainer.pl changed and I didn't notice and I wasn't careful. Eric, could Mohan just fix his patch before it gets merged or is it better to send these as two patches? regards, dan carpenter Ps: Mohon the patch is here: http://marc.info/?l=linux-netdev&m9512381528034&w=2