From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Date: Fri, 18 Feb 2011 09:39:57 +0000 Subject: Re: [patch -next] x86, microcode, AMD: signedness bug in Message-Id: <20110218093957.GA29723@aftab> List-Id: References: <20110218091716.GA4384@bicker> In-Reply-To: <20110218091716.GA4384@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Ingo Molnar Cc: Andreas Herrmann , Thomas Gleixner , "H. Peter Anvin" , "maintainer:X86 ARCHITECTURE..." , "open list:AMD MICROCODE UPD..." , open list , kernel-janitors@vger.kernel.org On Fri, Feb 18, 2011 at 04:17:16AM -0500, Dan Carpenter wrote: > install_equiv_cpu_table() returns type int. It uses negative error > codes so using an unsigned type breaks the error handling. > > Signed-off-by: Dan Carpenter Yes, my bad, sorry. Acked-by: Borislav Petkov Ingo, this should go ontop of tip/x86/microcode please, for it fixes 10de52d6655e ("x86, microcode, AMD: Simplify install_equiv_cpu_table"). Thanks a bunch. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632