* [PATCH 0/3] Staging: xgifb: Removes dead code and unused spinlock conditional compilation logic
@ 2011-02-21 9:09 Javier Martinez Canillas
2011-02-21 9:43 ` [PATCH 0/3] Staging: xgifb: Removes dead code and unused Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2011-02-21 9:09 UTC (permalink / raw)
To: kernel-janitors
In an earlier patch-set I was replacing a set of defines in staging xgifb driver
that hides the synchronization mechanism used to access critical sections.
As Dan Carpenter pointed me, this code depende on the accelerator engine being
activated (XGIfb_accel != 0), but in current driver this seems to be always
deactivated (XGIfb_accel = 0).
So this patchset removes all the unused code and this spinlock conditional
compilation logic only used in the acceleration mode code.
The patch-set is composed of the following patches:
[PATCH 1/3] Staging: xgifb: Removes dead code
[PATCH 2/3] Staging: xgifb: Remove unused functions
[PATCH 3/3] Staging: xgifb: Remove unused spinlock conditional compilation logic
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/3] Staging: xgifb: Removes dead code and unused
2011-02-21 9:09 [PATCH 0/3] Staging: xgifb: Removes dead code and unused spinlock conditional compilation logic Javier Martinez Canillas
@ 2011-02-21 9:43 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2011-02-21 9:43 UTC (permalink / raw)
To: kernel-janitors
On Mon, Feb 21, 2011 at 10:09:04AM +0100, Javier Martinez Canillas wrote:
> [PATCH 1/3] Staging: xgifb: Removes dead code
> [PATCH 2/3] Staging: xgifb: Remove unused functions
> [PATCH 3/3] Staging: xgifb: Remove unused spinlock conditional compilation logic
Acked-by: Dan Carpenter <error27@gmail.com>
Looks good. If you wanted to send some follow on patches, there are
some related things you could delete as well.
1) All references to XGIfb_accel in drivers/staging/xgifb/XGI_accel.h
and drivers/staging/xgifb/XGI_main_26.c
2) spinlock_t lockaccel; from the video_info struct in
drivers/staging/xgifb/XGIfb.h
3) The fbcon_XGI_sync() function doesn't do anything. You can delete
all references to it. Leave the ->fb_sync function pointer NULL.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-21 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-21 9:09 [PATCH 0/3] Staging: xgifb: Removes dead code and unused spinlock conditional compilation logic Javier Martinez Canillas
2011-02-21 9:43 ` [PATCH 0/3] Staging: xgifb: Removes dead code and unused Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox