From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging: xgifb: Remove unused function
Date: Mon, 21 Feb 2011 17:26:09 +0000 [thread overview]
Message-ID: <20110221172609.GK1898@bicker> (raw)
In-Reply-To: <1298279347-8825-4-git-send-email-martinez.javier@gmail.com>
On Mon, Feb 21, 2011 at 06:16:45PM +0100, Javier Martinez Canillas wrote:
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -1741,7 +1741,7 @@ static struct fb_ops XGIfb_ops = {
> .fb_fillrect = fbcon_XGI_fillrect,
> .fb_copyarea = fbcon_XGI_copyarea,
> .fb_imageblit = cfb_imageblit,
> - .fb_sync = fbcon_XGI_sync,
> + .fb_sync = NULL,
It doesn't need to be set explicitly. It gets initialized to NULL
automatically by default.
regards,
dan carpenter
> .fb_ioctl = XGIfb_ioctl,
> /* .fb_mmap = XGIfb_mmap, */
> };
> --
> 1.7.0.4
next prev parent reply other threads:[~2011-02-21 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 9:09 [PATCH 3/3] Staging: xgifb: Remove unused spinlock conditional compilation logic Javier Martinez Canillas
2011-02-21 17:16 ` [PATCH 3/3] Staging: xgifb: Remove unused function fbcon_XGI_sync Javier Martinez Canillas
2011-02-21 17:26 ` Dan Carpenter [this message]
2011-02-21 17:32 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221172609.GK1898@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox