From: Wim Van Sebroeck <wim@iguana.be>
To: Dan Carpenter <error27@gmail.com>
Cc: linux-watchdog@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] watchdog: sch311x_wdt: fix printk condition
Date: Wed, 23 Feb 2011 20:59:44 +0000 [thread overview]
Message-ID: <20110223205944.GP3790@infomag.iguana.be> (raw)
In-Reply-To: <20110223202601.GH19898@bicker>
Hi Dan,
> "=" has higher precedence than "&". Since
> if (sch311x_sio_inb(sio_config_port, 0x30) & (0x01 = 0)) is always
> false the message is never printed.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> Btw, is this printk() even worth printing?
Patch will be added.
About the printk -> need to look into the data sheet for that... We might need to exit the driver or activate it or ...
Kind regards,
Wim.
prev parent reply other threads:[~2011-02-23 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 20:26 [patch] watchdog: sch311x_wdt: fix printk condition Dan Carpenter
2011-02-23 20:59 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223205944.GP3790@infomag.iguana.be \
--to=wim@iguana.be \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox