From: Mattia Dongili <malattia@linux.it>
To: Dan Carpenter <error27@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/4] sony-laptop: make a couple variables static
Date: Sun, 27 Feb 2011 12:12:59 +0000 [thread overview]
Message-ID: <20110227121259.GB29319@kamineko.org> (raw)
In-Reply-To: <20110226125427.GI18043@bicker>
On Sat, Feb 26, 2011 at 03:54:27PM +0300, Dan Carpenter wrote:
> Sparse complains that these variables should be static.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Mattia Dongili <malattia@linux.it>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index a0ba0e7..a7b9c72 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -745,7 +745,7 @@ struct sony_nc_handles {
> struct device_attribute devattr;
> };
>
> -struct sony_nc_handles *handles;
> +static struct sony_nc_handles *handles;
>
> static ssize_t sony_nc_handles_show(struct device *dev,
> struct device_attribute *attr, char *buffer)
> @@ -1358,7 +1358,7 @@ struct kbd_backlight {
> struct device_attribute timeout_attr;
> };
>
> -struct kbd_backlight *kbdbl_handle;
> +static struct kbd_backlight *kbdbl_handle;
>
> static ssize_t __sony_nc_kbd_backlight_mode_set(u8 value)
> {
--
mattia
:wq!
next prev parent reply other threads:[~2011-02-27 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 12:54 [patch 1/4] sony-laptop: make a couple variables static Dan Carpenter
2011-02-27 12:12 ` Mattia Dongili [this message]
2011-03-11 17:31 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110227121259.GB29319@kamineko.org \
--to=malattia@linux.it \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox