From: Mattia Dongili <malattia@linux.it>
To: Dan Carpenter <error27@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 3/3] sony-laptop: handle allocation failures
Date: Sun, 27 Feb 2011 12:14:42 +0000 [thread overview]
Message-ID: <20110227121442.GC29319@kamineko.org> (raw)
In-Reply-To: <20110226125524.GK18043@bicker>
On Sat, Feb 26, 2011 at 03:55:24PM +0300, Dan Carpenter wrote:
> Return -ENOMEM if kzalloc() fails. The callers already handle error
> returns.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Mattia Dongili <malattia@linux.it>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index d0d0522..0db9049 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -768,6 +768,8 @@ static int sony_nc_handles_setup(struct platform_device *pd)
> int result;
>
> handles = kzalloc(sizeof(*handles), GFP_KERNEL);
> + if (!handles)
> + return -ENOMEM;
>
> sysfs_attr_init(&handles->devattr.attr);
> handles->devattr.attr.name = "handles";
> @@ -1458,6 +1460,8 @@ static int sony_nc_kbd_backlight_setup(struct platform_device *pd)
> return 0;
>
> kbdbl_handle = kzalloc(sizeof(*kbdbl_handle), GFP_KERNEL);
> + if (!kbdbl_handle)
> + return -ENOMEM;
>
> sysfs_attr_init(&kbdbl_handle->mode_attr.attr);
> kbdbl_handle->mode_attr.attr.name = "kbd_backlight";
--
mattia
:wq!
prev parent reply other threads:[~2011-02-27 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 12:55 [patch 3/3] sony-laptop: handle allocation failures Dan Carpenter
2011-02-27 12:14 ` Mattia Dongili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110227121442.GC29319@kamineko.org \
--to=malattia@linux.it \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox