From: Greg KH <gregkh@suse.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: generic_serial: fix double locking bug
Date: Mon, 28 Feb 2011 21:06:03 +0000 [thread overview]
Message-ID: <20110228210603.GA8320@suse.de> (raw)
In-Reply-To: <20110228192831.GI18043@bicker>
On Mon, Feb 28, 2011 at 10:28:31PM +0300, Dan Carpenter wrote:
> spin_lock_irqsave() is not nestable. The second time that it gets
> called it overwrites the "flags" variable and so IRQs can't be restored
> properly.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> Oh. Crap. I don't want to adopt these drivers. But I already wrote
> the patch before I read the TODO file, so I'm still going to submit it.
Heh, don't worry, you don't "own" them, I'll just take this fix for now
and still leave them in the "abandoned" category :)
thanks,
greg k-h
prev parent reply other threads:[~2011-02-28 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 19:28 [patch] Staging: generic_serial: fix double locking bug Dan Carpenter
2011-02-28 21:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110228210603.GA8320@suse.de \
--to=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox