From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: minor bug ?
Date: Tue, 01 Mar 2011 17:53:30 +0000 [thread overview]
Message-ID: <20110301175329.GV18043@bicker> (raw)
In-Reply-To: <20110301154301.GS18043@bicker>
On Tue, Mar 01, 2011 at 06:39:53PM +0100, Nicolas Kaiser wrote:
> find /usr/src/linux/ -name "*.[ch]"| \
> xargs egrep "^[[:space:]]*struct [^[:space:])]*;"| \
> sort|uniq -d
>
>
> /usr/src/linux/arch/arm/include/asm/elf.h:struct task_struct;
> /usr/src/linux/arch/microblaze/include/asm/prom.h:struct pci_dev;
> /usr/src/linux/arch/parisc/include/asm/dma-mapping.h:struct parisc_device;
> /usr/src/linux/arch/powerpc/include/asm/prom.h:struct pci_dev;
> /usr/src/linux/arch/s390/include/asm/ccwdev.h:struct ccw1;
> /usr/src/linux/arch/s390/kernel/compat_linux.h:struct old_sigaction32;
> /usr/src/linux/arch/x86/include/asm/io_apic.h:struct io_apic_irq_attr;
I just looked through some of these at random. For this one
removing either struct io_apic_irq_attr will break the compile. It
depends on how CONFIG_X86_IO_APIC is configured if it will break *your*
compile or not.
Sending cleanup patches that break the compile makes people really
angry, so be careful.
regards,
dan carpenter
next prev parent reply other threads:[~2011-03-01 17:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 15:43 minor bug ? Dan Carpenter
2011-03-01 15:44 ` Prashant Shah
2011-03-01 17:39 ` Nicolas Kaiser
2011-03-01 17:53 ` Dan Carpenter [this message]
2011-03-01 18:22 ` Randy Dunlap
2011-03-01 18:43 ` Dan Carpenter
2011-03-01 18:50 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301175329.GV18043@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox