From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Sun, 06 Mar 2011 13:26:21 +0000 Subject: [patch] cifs: writing past the end of the array Message-Id: <20110306132621.GN3416@bicker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steve French Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org This is a cut and paste error. p16 only has 16 chars, not 21. Signed-off-by: Dan Carpenter diff --git a/fs/cifs/smbencrypt.c b/fs/cifs/smbencrypt.c index 3967635..1525d5e 100644 --- a/fs/cifs/smbencrypt.c +++ b/fs/cifs/smbencrypt.c @@ -353,7 +353,7 @@ SMBNTencrypt(unsigned char *passwd, unsigned char *c8, unsigned char *p24) int rc; unsigned char p16[16], p21[21]; - memset(p16, '\0', 21); + memset(p16, '\0', 16); memset(p21, '\0', 21); rc = E_md4hash(passwd, p16);