* Re: [patch] cifs: writing past the end of the array
2011-03-06 13:26 [patch] cifs: writing past the end of the array Dan Carpenter
@ 2011-03-06 14:56 ` Shirish Pargaonkar
2011-03-06 17:11 ` walter harms
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Shirish Pargaonkar @ 2011-03-06 14:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: Steve French, linux-cifs-u79uwXL29TY76Z2rM5mHXA,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Sun, Mar 6, 2011 at 7:26 AM, Dan Carpenter <error27@gmail.com> wrote:
> This is a cut and paste error. p16 only has 16 chars, not 21.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/cifs/smbencrypt.c b/fs/cifs/smbencrypt.c
> index 3967635..1525d5e 100644
> --- a/fs/cifs/smbencrypt.c
> +++ b/fs/cifs/smbencrypt.c
> @@ -353,7 +353,7 @@ SMBNTencrypt(unsigned char *passwd, unsigned char *c8, unsigned char *p24)
> int rc;
> unsigned char p16[16], p21[21];
>
> - memset(p16, '\0', 21);
> + memset(p16, '\0', 16);
> memset(p21, '\0', 21);
>
> rc = E_md4hash(passwd, p16);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Looks correct.
Reviewed-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] cifs: writing past the end of the array
2011-03-06 13:26 [patch] cifs: writing past the end of the array Dan Carpenter
2011-03-06 14:56 ` Shirish Pargaonkar
@ 2011-03-06 17:11 ` walter harms
[not found] ` <4D73C03B.1050905-fPG8STNUNVg@public.gmane.org>
2011-03-08 8:25 ` walter harms
2011-03-08 11:05 ` Dan Carpenter
3 siblings, 1 reply; 6+ messages in thread
From: walter harms @ 2011-03-06 17:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: Steve French, linux-cifs-u79uwXL29TY76Z2rM5mHXA,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
Am 06.03.2011 14:26, schrieb Dan Carpenter:
> This is a cut and paste error. p16 only has 16 chars, not 21.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/cifs/smbencrypt.c b/fs/cifs/smbencrypt.c
> index 3967635..1525d5e 100644
> --- a/fs/cifs/smbencrypt.c
> +++ b/fs/cifs/smbencrypt.c
> @@ -353,7 +353,7 @@ SMBNTencrypt(unsigned char *passwd, unsigned char *c8, unsigned char *p24)
> int rc;
> unsigned char p16[16], p21[21];
>
> - memset(p16, '\0', 21);
> + memset(p16, '\0', 16);
> memset(p21, '\0', 21);
>
> rc = E_md4hash(passwd, p16);
perhaps ARRAY_SIZE() instead of a magic number is a better choice ?
re,
wh
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] cifs: writing past the end of the array
2011-03-06 13:26 [patch] cifs: writing past the end of the array Dan Carpenter
2011-03-06 14:56 ` Shirish Pargaonkar
2011-03-06 17:11 ` walter harms
@ 2011-03-08 8:25 ` walter harms
2011-03-08 11:05 ` Dan Carpenter
3 siblings, 0 replies; 6+ messages in thread
From: walter harms @ 2011-03-08 8:25 UTC (permalink / raw)
To: kernel-janitors
Am 07.03.2011 17:09, schrieb Jeff Layton:
> On Sun, 06 Mar 2011 18:11:23 +0100
> walter harms <wharms@bfs.de> wrote:
>
>>
>>
>> Am 06.03.2011 14:26, schrieb Dan Carpenter:
>>> This is a cut and paste error. p16 only has 16 chars, not 21.
>>>
>>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>>>
>>> diff --git a/fs/cifs/smbencrypt.c b/fs/cifs/smbencrypt.c
>>> index 3967635..1525d5e 100644
>>> --- a/fs/cifs/smbencrypt.c
>>> +++ b/fs/cifs/smbencrypt.c
>>> @@ -353,7 +353,7 @@ SMBNTencrypt(unsigned char *passwd, unsigned char *c8, unsigned char *p24)
>>> int rc;
>>> unsigned char p16[16], p21[21];
>>>
>>> - memset(p16, '\0', 21);
>>> + memset(p16, '\0', 16);
>>> memset(p21, '\0', 21);
>>>
>>> rc = E_md4hash(passwd, p16);
>>
>>
>> perhaps ARRAY_SIZE() instead of a magic number is a better choice ?
>>
>
> Agreed. Care to propose a patch? There are almost certainly other
> places in the code that could use a similar cleanup.
>
Dan, i think he is sending to you :)
re,
wh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] cifs: writing past the end of the array
2011-03-06 13:26 [patch] cifs: writing past the end of the array Dan Carpenter
` (2 preceding siblings ...)
2011-03-08 8:25 ` walter harms
@ 2011-03-08 11:05 ` Dan Carpenter
3 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2011-03-08 11:05 UTC (permalink / raw)
To: kernel-janitors
On Tue, Mar 08, 2011 at 09:25:36AM +0100, walter harms wrote:
> >>> --- a/fs/cifs/smbencrypt.c
> >>> +++ b/fs/cifs/smbencrypt.c
> >>> @@ -353,7 +353,7 @@ SMBNTencrypt(unsigned char *passwd, unsigned char *c8, unsigned char *p24)
> >>> int rc;
> >>> unsigned char p16[16], p21[21];
> >>>
> >>> - memset(p16, '\0', 21);
> >>> + memset(p16, '\0', 16);
> >>> memset(p21, '\0', 21);
> >>>
> >>> rc = E_md4hash(passwd, p16);
> >>
> >>
> >> perhaps ARRAY_SIZE() instead of a magic number is a better choice ?
> >>
> >
> > Agreed. Care to propose a patch? There are almost certainly other
> > places in the code that could use a similar cleanup.
> >
>
> Dan, i think he is sending to you :)
>
Nah, man. He's talking to you. :P
The 16 can't change. It's built into the name. Also you should
probably use sizeof() instead of ARRAY_SIZE(). They're the same in this
case because it's type char but sizeof is more standard.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread