* [patch 1/4] sony-laptop: make a couple variables static
@ 2011-02-26 12:54 Dan Carpenter
2011-02-27 12:12 ` Mattia Dongili
2011-03-11 17:31 ` Matthew Garrett
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2011-02-26 12:54 UTC (permalink / raw)
To: Mattia Dongili; +Cc: Matthew Garrett, platform-driver-x86, kernel-janitors
Sparse complains that these variables should be static.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index a0ba0e7..a7b9c72 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -745,7 +745,7 @@ struct sony_nc_handles {
struct device_attribute devattr;
};
-struct sony_nc_handles *handles;
+static struct sony_nc_handles *handles;
static ssize_t sony_nc_handles_show(struct device *dev,
struct device_attribute *attr, char *buffer)
@@ -1358,7 +1358,7 @@ struct kbd_backlight {
struct device_attribute timeout_attr;
};
-struct kbd_backlight *kbdbl_handle;
+static struct kbd_backlight *kbdbl_handle;
static ssize_t __sony_nc_kbd_backlight_mode_set(u8 value)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch 1/4] sony-laptop: make a couple variables static
2011-02-26 12:54 [patch 1/4] sony-laptop: make a couple variables static Dan Carpenter
@ 2011-02-27 12:12 ` Mattia Dongili
2011-03-11 17:31 ` Matthew Garrett
1 sibling, 0 replies; 3+ messages in thread
From: Mattia Dongili @ 2011-02-27 12:12 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Matthew Garrett, platform-driver-x86, kernel-janitors
On Sat, Feb 26, 2011 at 03:54:27PM +0300, Dan Carpenter wrote:
> Sparse complains that these variables should be static.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Mattia Dongili <malattia@linux.it>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index a0ba0e7..a7b9c72 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -745,7 +745,7 @@ struct sony_nc_handles {
> struct device_attribute devattr;
> };
>
> -struct sony_nc_handles *handles;
> +static struct sony_nc_handles *handles;
>
> static ssize_t sony_nc_handles_show(struct device *dev,
> struct device_attribute *attr, char *buffer)
> @@ -1358,7 +1358,7 @@ struct kbd_backlight {
> struct device_attribute timeout_attr;
> };
>
> -struct kbd_backlight *kbdbl_handle;
> +static struct kbd_backlight *kbdbl_handle;
>
> static ssize_t __sony_nc_kbd_backlight_mode_set(u8 value)
> {
--
mattia
:wq!
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 1/4] sony-laptop: make a couple variables static
2011-02-26 12:54 [patch 1/4] sony-laptop: make a couple variables static Dan Carpenter
2011-02-27 12:12 ` Mattia Dongili
@ 2011-03-11 17:31 ` Matthew Garrett
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Garrett @ 2011-03-11 17:31 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Mattia Dongili, platform-driver-x86, kernel-janitors
Applied the series, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-11 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-26 12:54 [patch 1/4] sony-laptop: make a couple variables static Dan Carpenter
2011-02-27 12:12 ` Mattia Dongili
2011-03-11 17:31 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox