* [patch 1/2] asus-wmi: signedness bug in read_brightness()
@ 2011-03-15 7:06 Dan Carpenter
2011-03-15 7:27 ` Corentin Chary
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-03-15 7:06 UTC (permalink / raw)
To: Corentin Chary
Cc: Matthew Garrett, acpi4asus-user, platform-driver-x86,
kernel-janitors
"err" needs to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 5b779a9..a038595 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -946,7 +946,8 @@ static int read_brightness_max(struct asus_wmi *asus)
static int read_brightness(struct backlight_device *bd)
{
struct asus_wmi *asus = bl_get_data(bd);
- u32 retval, err;
+ u32 retval;
+ int err;
err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch 1/2] asus-wmi: signedness bug in read_brightness()
2011-03-15 7:06 [patch 1/2] asus-wmi: signedness bug in read_brightness() Dan Carpenter
@ 2011-03-15 7:27 ` Corentin Chary
0 siblings, 0 replies; 2+ messages in thread
From: Corentin Chary @ 2011-03-15 7:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Matthew Garrett, acpi4asus-user, platform-driver-x86,
kernel-janitors
On Tue, Mar 15, 2011 at 8:06 AM, Dan Carpenter <error27@gmail.com> wrote:
> "err" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 5b779a9..a038595 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -946,7 +946,8 @@ static int read_brightness_max(struct asus_wmi *asus)
> static int read_brightness(struct backlight_device *bd)
> {
> struct asus_wmi *asus = bl_get_data(bd);
> - u32 retval, err;
> + u32 retval;
> + int err;
>
> err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);
Hm, Thanks,
Acked-by: Corentin Chary <corentin.chary@gmail.com>
--
Corentin Chary
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-15 7:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-15 7:06 [patch 1/2] asus-wmi: signedness bug in read_brightness() Dan Carpenter
2011-03-15 7:27 ` Corentin Chary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox