public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@freescale.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Steve Cornelius <sec@pobox.com>,
	linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] crypto: caam - ARRAY_SIZE() vs sizeof()
Date: Tue, 15 Mar 2011 22:20:37 +0000	[thread overview]
Message-ID: <20110315172037.f212db80.kim.phillips@freescale.com> (raw)
In-Reply-To: <20110315065955.GP2008@bicker>

On Tue, 15 Mar 2011 09:59:55 +0300
Dan Carpenter <error27@gmail.com> wrote:

> ARRAY_SIZE() was intended here instead of sizeof().  sizeof() is four
> times larger than ARRAY_SIZE().  outstr is normally 256 chars so 
> printing garbage to it could overfill the buffer and corrupt memory.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Acked-by: Kim Phillips <kim.phillips@freescale.com>

Thanks Dan,

Kim


  reply	other threads:[~2011-03-15 22:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15  6:59 [patch] crypto: caam - ARRAY_SIZE() vs sizeof() Dan Carpenter
2011-03-15 22:20 ` Kim Phillips [this message]
2011-03-23 13:22   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110315172037.f212db80.kim.phillips@freescale.com \
    --to=kim.phillips@freescale.com \
    --cc=davem@davemloft.net \
    --cc=error27@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=sec@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox