* [patch 2/4] USB: musb: using 0 instead of NULL
@ 2011-03-20 11:15 Dan Carpenter
2011-03-22 9:21 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-03-20 11:15 UTC (permalink / raw)
To: kernel-janitors
Sparse complains (and rightly so):
drivers/usb/musb/cppi_dma.c:1458:33:
warning: Using plain integer as NULL pointer
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/usb/musb/cppi_dma.c b/drivers/usb/musb/cppi_dma.c
index 6385eeb..0db0f5e 100644
--- a/drivers/usb/musb/cppi_dma.c
+++ b/drivers/usb/musb/cppi_dma.c
@@ -1455,7 +1455,7 @@ static int cppi_channel_abort(struct dma_channel *channel)
* compare mode by writing 1 to the tx_complete register.
*/
cppi_reset_tx(tx_ram, 1);
- cppi_ch->head = 0;
+ cppi_ch->head = NULL;
musb_writel(&tx_ram->tx_complete, 0, 1);
cppi_dump_tx(5, cppi_ch, " (done teardown)");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 2/4] USB: musb: using 0 instead of NULL
2011-03-20 11:15 [patch 2/4] USB: musb: using 0 instead of NULL Dan Carpenter
@ 2011-03-22 9:21 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2011-03-22 9:21 UTC (permalink / raw)
To: kernel-janitors
On Sun, Mar 20, 2011 at 02:15:24PM +0300, Dan Carpenter wrote:
> Sparse complains (and rightly so):
> drivers/usb/musb/cppi_dma.c:1458:33:
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
applied, thanks
--
balbi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-22 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-20 11:15 [patch 2/4] USB: musb: using 0 instead of NULL Dan Carpenter
2011-03-22 9:21 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox