From: Florian Fainelli <florian@openwrt.org>
To: Dan Carpenter <error27@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] vlynq: fix resource size calculation
Date: Mon, 21 Mar 2011 12:25:48 +0000 [thread overview]
Message-ID: <201103211325.49061.florian@openwrt.org> (raw)
In-Reply-To: <20110319043813.GA2008@bicker>
On Saturday 19 March 2011 05:38:13 Dan Carpenter wrote:
> The original code had an off-by-one error so we didn't release the
> entire memory region on remove().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Florian Fainelli <florian@openwrt.org>
>
> diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> index f885c86..1d37553 100644
> --- a/drivers/vlynq/vlynq.c
> +++ b/drivers/vlynq/vlynq.c
> @@ -764,7 +764,7 @@ static int vlynq_remove(struct platform_device *pdev)
>
> device_unregister(&dev->dev);
> iounmap(dev->local);
> - release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
> + release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start + 1);
>
> kfree(dev);
prev parent reply other threads:[~2011-03-21 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 4:38 [patch] vlynq: fix resource size calculation Dan Carpenter
2011-03-21 12:25 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103211325.49061.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox