From: Rafael Aquini <aquini@linux.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Joe Perches <joe@perches.com>,
kernel-janitors@vger.kernel.org,
David Miller <davem@davemloft.net>,
Andy Gospodarek <andy@greyhouse.net>,
shemminger@vyatta.com, netdev@vger.kernel.org,
Nicolas Kaiser <nikai@nikai.net>
Subject: Re: [PATCH] net/bonding: adjust codingstyle for bond_3ad files
Date: Sat, 07 May 2011 21:37:16 +0000 [thread overview]
Message-ID: <20110507213714.GA2507@x61.tchesoft.com> (raw)
In-Reply-To: <23896.1304803541@death>
Howdy Jay,
On Sat, May 07, 2011 at 02:25:41PM -0700, Jay Vosburgh wrote:
> My preference would be to only remove the "silence compiler"
> comments if the possibility of silent misbehavior is also eliminated.
> For __ad_timer_to_ticks, that would mean either a default: case in the
> current arrangement, or something like what Joe suggests above.
>
> If this is beyond the scope of what you, Rafeal, want to do,
> that's fine, but in that case leave the "silence" notes in place.
Yeah, re-factor that sort of code was beyond my intentions when I first
submit the patch. However, it is certainly feasible to be done, and as I wrote
before, I'm more than willing to help where is needed to help.
I'll review the places where "silence" notes are placed, and try to figure out a
proper way to get rid of them.
Thank you, folks, for keep hitting me with valuable feedback.
Cheers!
--
Rafael Aquini <aquini@linux.com>
next prev parent reply other threads:[~2011-05-07 21:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 11:50 [PATCH] net/bonding: adjust codingstyle for bond_3ad files Rafael Aquini
2011-05-06 13:01 ` Nicolas Kaiser
2011-05-06 14:56 ` Rafael Aquini
2011-05-07 1:27 ` Rafael Aquini
2011-05-07 1:51 ` Joe Perches
2011-05-07 17:31 ` Rafael Aquini
2011-05-07 18:02 ` Joe Perches
2011-05-07 19:35 ` matt mooney
2011-05-07 20:24 ` Joe Perches
2011-05-08 23:08 ` Håkon Løvdal
2011-05-08 23:10 ` David Miller
2011-05-09 0:08 ` Håkon Løvdal
2011-05-09 0:12 ` David Miller
2011-05-09 1:30 ` Håkon Løvdal
2011-05-07 21:25 ` Jay Vosburgh
2011-05-07 21:37 ` Rafael Aquini [this message]
2011-05-10 0:08 ` Rafael Aquini
2011-05-10 0:15 ` Joe Perches
2011-05-10 2:00 ` Jay Vosburgh
2011-05-10 2:11 ` Joe Perches
2011-05-10 12:22 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110507213714.GA2507@x61.tchesoft.com \
--to=aquini@linux.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikai@nikai.net \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox