Re: [PATCH 06/12] staging: usbip: stub_main.c: code cleanup

Greg KH
2011-05-11T21:08:37Z

On Wed, May 11, 2011 at 01:54:18AM -0700, matt mooney wrote:
> Reorder functions; remove match_find() and replace with
> get_busid_idx(); change other functions to use get_busid_idx(); and
> code cleanup in the other functions.
>
> Signed-off-by: matt mooney <mfm@muteddisk.com>
> ---
> I apologize for this one. I realize that I should have split it into two with
> the reorder being separate.

Yes, please split it up.

> Also, it seems as if there is a synchronization problem carried over from the
> original code in get_busid_priv(). An address into the busid_table is returned
> and then the element is accessed and modified elsewhere. Right? Or am I missing
> something.

You might be correct, I don't really know.

thanks,

greg k-h