Re: [PATCH 00/12] staging: usbip: miscellaneous code cleanup

matt mooney
2011-05-11T23:08:07Z

On Wed, May 11, 2011 at 2:14 PM, Greg KH <greg@kroah.com> wrote:
> On Wed, May 11, 2011 at 01:54:12AM -0700, matt mooney wrote:
>> Hi Greg,
>>
>> I am interested in hearing your thoughts on the userspace interface?
>
> Which one?  The user/kernel interface?

Yes.

>
>> Even as is, it definitely needs some work. For one thing I was thinking
>> of removing the debug flag from userspace. The userspace utilites are
>> not using it anyway, and it is not 100% working yet.
>
> I haven't looked at the interface much yet, what is your issue with the
> debug flag?

I guess it just added a lot of code (most was actually eliminated in
the pr_*() change), is not complete, and is inconsistently used. But I
see that it would be helpful especially due to the amount of debug
messages printed by default. So ignore that complaint.

> To make things easier, and allow you to be able to change the userspace
> interface, I suggest moving the userspace code into the kernel tree, and
> building it here.  That would allow you to move forward with changing
> things easier, doing it all in one place allows you to keep stuff in
> sync, and provides people an easier way to actually get the needed tools
> to drive the code.
>
> What do you think about doing that?

Sure, I didn't even know that was an option. How do you propose that
is done though?

> I've applied a number of these patches, care to respin the others and
> resend them based on my latest tree?

Okay, I will do that. I noticed some were missed but that may be
because they depended on a few of the unapplied ones anyway, so I will
also resend those as well.

--
GPG-Key: 9AFE00EA
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html