From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Dietsche Date: Fri, 01 Jul 2011 01:13:57 +0000 Subject: Re: [PATCH] x86: smpboot: mark array as const Message-Id: <20110701011357.GA18952@farmergreg.com> List-Id: References: <1309473108-5337-1-git-send-email-Gregory.Dietsche@cuw.edu> In-Reply-To: <1309473108-5337-1-git-send-email-Gregory.Dietsche@cuw.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On Thu, Jun 30, 2011 at 05:23:03PM -0700, H. Peter Anvin wrote: > On 06/30/2011 03:31 PM, Greg Dietsche wrote: > > This array is read-only. Make it explicit by marking as const. > > > > Signed-off-by: Greg Dietsche > > --- > > arch/x86/kernel/smpboot.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > > index 9fd3137..4218569 100644 > > --- a/arch/x86/kernel/smpboot.c > > +++ b/arch/x86/kernel/smpboot.c > > @@ -438,7 +438,7 @@ static void impress_friends(void) > > void __inquire_remote_apic(int apicid) > > { > > unsigned i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 }; > > - char *names[] = { "ID", "VERSION", "SPIV" }; > > + const char const *names[] = { "ID", "VERSION", "SPIV" }; > > int timeout; > > Did you mean "const char * const" here? doh! Yes, i did! Sorry I missed this email the first time around - my procmail rules need a little work.... Greg > -hpa > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >