From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Date: Fri, 01 Jul 2011 07:15:05 +0000 Subject: Re: [PATCH 9/10] arch/arm/mach-omap2/clock.c: add missing clk_put Message-Id: <20110701071505.GB23145@atomide.com> List-Id: References: <1306948213-20767-9-git-send-email-julia@diku.dk> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org * Paul Walmsley [110602 14:22]: > On Wed, 1 Jun 2011, Julia Lawall wrote: > > > From: Julia Lawall > > > > Add missing call to clk_put. > > > > A simplified version of the semantic match that finds this problem is as > > follows: (http://coccinelle.lip6.fr/) > > > > // > > @r exists@ > > expression e1,e2; > > statement S; > > @@ > > > > e1 = clk_get@p1(...); > > ... when != e1 = e2 > > when != clk_put(e1) > > when any > > if (...) { ... when != clk_put(e1) > > when != if (...) { ... clk_put(e1) ... } > > * return@p3 ...; > > } else S > > // > > > > Signed-off-by: Julia Lawall > > Acked-by: Paul Walmsley Adding this into devel-fixes branch. Tony