From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Ortiz <sameo@linux.intel.com>
Date: Wed, 06 Jul 2011 18:32:08 +0000
Subject: Re: [patch] regulator/tps65912: storing error codes in u8
Message-Id: <20110706183208.GK3021@sortiz-mobl>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20110623055715.GM14591@shale.localdomain>
 <1309795618.3272.9.camel@odin>
In-Reply-To: <1309795618.3272.9.camel@odin>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Liam Girdwood <lrg@kernel.org>
Cc: Dan Carpenter <error27@gmail.com>, Liam Girdwood <lrg@ti.com>, Mark Brown <broonie@opensource.wolfsonmicro.com>, open list <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org

Hi Liam,

On Mon, Jul 04, 2011 at 05:06:58PM +0100, Liam Girdwood wrote:
> On Thu, 2011-06-23 at 08:57 +0300, Dan Carpenter wrote:
> > get_ctrl_reg() returns -EINVAL so the error handling won't work here
> > if reg is a u8.
> > 
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > 
> > diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c
> > index d2c6542..3a9313e 100644
> > --- a/drivers/regulator/tps65912-regulator.c
> > +++ b/drivers/regulator/tps65912-regulator.c
> > @@ -417,7 +417,7 @@ static int tps65912_reg_enable(struct regulator_dev *dev)
> >  	struct tps65912_reg *pmic = rdev_get_drvdata(dev);
> >  	struct tps65912 *mfd = pmic->mfd;
> >  	int id = rdev_get_id(dev);
> > -	u8 reg;
> > +	int reg;
> >  
> >  	if (id < TPS65912_REG_DCDC1 || id > TPS65912_REG_LDO10)
> >  		return -EINVAL;
> 
> Samuel, would you mind taking this since tps65912 is upstreaming via
> mfd.
Sure. Would you mind sending the patch to me ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/