Re: [patch] skbuff: use kfree_skb() instead of kfree()

Julia Lawall
2011-07-20T08:37:11Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1264 bytes --]

On Wed, 20 Jul 2011, Eric Dumazet wrote:

> Le mercredi 20 juillet 2011 à 11:01 +0300, Dan Carpenter a écrit :
> > On Wed, Jul 20, 2011 at 09:42:03AM +0200, Eric Dumazet wrote:
> > > Le mercredi 20 juillet 2011 à 10:25 +0300, Dan Carpenter a écrit :
> > > > Crap. Sorry, I shouldn't have sent that. We shouldn't return the
> > > > freed "n" here. I'll send a v2 shortly.
> > >
> > > Also, dont forget to say its a patch for net-next-2.6
> >
> > If you're using linux-next, is there a way to tell which tree a
> > patch came from? Obviously in this case it's core networking, but
> > in other cases how does that work?
>
> In this particular case, David will know for sure since patch is very
> recent, but I wanted to make a general advice.
>
> Keep in mind David has to review dozens of patches _per_ day, so netdev
> related patches need some extra cooperation from submitters to help the
> maintainer.
>
> This extra cooperation means to test the patch on either net-next-2.6 or
> net-2.6 tree ;)

Maybe there is some way to integrate such a suggestion in get_maintainers
or checkpatch? Otherwise, those who work on the code in a more breadth
first way don't have much chance of knowing or remembering this advice.

julia