public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: dagenaisj@sonatest.com
Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
	Andrew Morton <akpm@linux-foundation.org>,
	open list <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: [patch] w1: off by one in w1_f29_remove_slave()
Date: Wed, 27 Jul 2011 09:55:57 +0000	[thread overview]
Message-ID: <20110727095557.GL3824@shale.localdomain> (raw)

This reads past the end of the w1_f29_sysfs_bin_files[] array.  I
don't have this hardware, but I assume it crashes every time the
function is called.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c
index c377818..0da4e97 100644
--- a/drivers/w1/slaves/w1_ds2408.c
+++ b/drivers/w1/slaves/w1_ds2408.c
@@ -373,7 +373,7 @@ static int w1_f29_add_slave(struct w1_slave *sl)
 static void w1_f29_remove_slave(struct w1_slave *sl)
 {
 	int i;
-	for (i = NB_SYSFS_BIN_FILES; i <= 0; --i)
+	for (i = NB_SYSFS_BIN_FILES - 1; i <= 0; --i)
 		sysfs_remove_bin_file(&sl->dev.kobj,
 			&(w1_f29_sysfs_bin_files[i]));
 }

             reply	other threads:[~2011-07-27  9:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-27  9:55 Dan Carpenter [this message]
2011-07-29 20:28 ` [patch] w1: off by one in w1_f29_remove_slave() Jean-François Dagenais
     [not found]   ` <CAOmT4fS1OqQb5KOOeFnGHt1tnYGBRutVrAZ4cXB6n=hou5fn8w@mail.gmail.com>
2011-07-29 22:55     ` Dan Carpenter
2011-07-30  8:19     ` [patch v2] w1: fix for loop " Dan Carpenter
2011-08-17 18:45       ` Jean-Francois Dagenais
2011-07-30  8:42   ` [patch] w1: off by one " walter harms
2011-07-30  8:51     ` Dan Carpenter
2011-08-17 18:42       ` Jean-Francois Dagenais

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110727095557.GL3824@shale.localdomain \
    --to=error27@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dagenaisj@sonatest.com \
    --cc=johnpol@2ka.mipt.ru \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox