From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrea Righi Date: Tue, 02 Aug 2011 20:09:34 +0000 Subject: Re: [PATCH 1/11] kernel/kfifo.c: trivial: use BUG_ON Message-Id: <20110802200934.GB2594@thinkpad> List-Id: References: <1312281304-11847-1-git-send-email-julia@diku.dk> <1312281304-11847-2-git-send-email-julia@diku.dk> <20110802113335.GA4185@thinkpad> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Andrew Morton , trivial@kernel.org, kernel-janitors@vger.kernel.org, Stefani Seibold , "Ira W. Snyder" , linux-kernel@vger.kernel.org On Tue, Aug 02, 2011 at 09:27:38PM +0200, Julia Lawall wrote: > From: Julia Lawall > > Allow the function to return 0 when 0 elements are asked for rather than > crashing the kernel with BUG. > > Signed-off-by: Julia Lawall Reviewed-by: Andrea Righi Thanks, -Andrea > > --- > var/julia/linuxcopy/kernel/kfifo.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff -u -p a/kernel/kfifo.c b/kernel/kfifo.c > index 01a0700..9f928ef 100644 > --- a/var/linuxes/linux-next/kernel/kfifo.c > +++ b/var/julia/linuxcopy/kernel/kfifo.c > @@ -562,9 +562,6 @@ EXPORT_SYMBOL(__kfifo_to_user_r); > unsigned int __kfifo_dma_in_prepare_r(struct __kfifo *fifo, > struct scatterlist *sgl, int nents, unsigned int len, size_t recsize) > { > - if (!nents) > - BUG(); > - > len = __kfifo_max_r(len, recsize); > > if (len + recsize > kfifo_unused(fifo)) > @@ -586,9 +583,6 @@ EXPORT_SYMBOL(__kfifo_dma_in_finish_r); > unsigned int __kfifo_dma_out_prepare_r(struct __kfifo *fifo, > struct scatterlist *sgl, int nents, unsigned int len, size_t recsize) > { > - if (!nents) > - BUG(); > - > len = __kfifo_max_r(len, recsize); > > if (len + recsize > fifo->in - fifo->out)