From: Wolfram Sang <w.sang@pengutronix.de>
To: Julia Lawall <julia@diku.dk>
Cc: Riku Voipio <riku.voipio@iki.fi>,
kernel-janitors@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drivers/leds/leds-pca9532.c: delete useless
Date: Fri, 05 Aug 2011 22:37:40 +0000 [thread overview]
Message-ID: <20110805223740.GA31186@pengutronix.de> (raw)
In-Reply-To: <1312453774-23333-5-git-send-email-julia@diku.dk>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On Thu, Aug 04, 2011 at 12:29:34PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Delete nontrivial initialization that is immediately overwritten by the
> result of an allocation function.
>
> The semantic match that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> type T;
> identifier i;
> expression e;
> @@
>
> (
> T i = \(0\|NULL\|ERR_PTR(...)\);
> |
> -T i = e;
> +T i;
> )
> ... when != i
> i = \(kzalloc\|kcalloc\|kmalloc\)(...);
>
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
BTW LED patches seem to go via akpm these days...
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2011-08-05 22:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 10:29 [PATCH 0/4] delete useless initialization Julia Lawall
2011-08-04 10:29 ` [PATCH 1/4] fs/ext3/balloc.c: " Julia Lawall
2011-08-04 10:40 ` Jan Kara
2011-08-04 10:29 ` [PATCH 2/4] fs/ext2/balloc.c: " Julia Lawall
2011-08-04 10:39 ` Jan Kara
2011-08-04 10:29 ` [PATCH 3/4] drivers/media/video/hexium_gemini.c: " Julia Lawall
2011-08-16 11:55 ` [PATCH 3/4] drivers/media/video/hexium_gemini.c: delete useless Jean Delvare
2011-08-04 10:29 ` [PATCH 4/4] drivers/leds/leds-pca9532.c: delete useless initialization Julia Lawall
2011-08-05 22:37 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110805223740.GA31186@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riku.voipio@iki.fi \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox