From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 09 Aug 2011 18:06:16 +0000 Subject: [patch] Staging: iio/dac/ad5504: uninitialized variable in error Message-Id: <20110809180616.GC3830@shale.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jonathan Cameron Cc: Greg Kroah-Hartman , Michael Hennerich , "open list:STAGING - INDUSTR..." , "open list:STAGING SUBSYSTEM" , kernel-janitors@vger.kernel.org If we hit the "goto error_disable_reg" then the "st" variable is uninitialized. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/iio/dac/ad5504.c b/drivers/staging/iio/dac/ad5504.c index 1915f45..88512dd 100644 --- a/drivers/staging/iio/dac/ad5504.c +++ b/drivers/staging/iio/dac/ad5504.c @@ -338,7 +338,7 @@ error_free_dev: iio_free_device(indio_dev); error_disable_reg: if (!IS_ERR(reg)) - regulator_disable(st->reg); + regulator_disable(reg); error_put_reg: if (!IS_ERR(reg)) regulator_put(reg);