From: Gustavo Padovan <padovan@profusion.mobi>
To: Dan Carpenter <error27@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"open list:BLUETOOTH SUBSYSTEM" <linux-bluetooth@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] bluetooth: unlock if allocation fails in
Date: Thu, 11 Aug 2011 19:35:34 +0000 [thread overview]
Message-ID: <20110811193533.GB19699@joana> (raw)
In-Reply-To: <20110803142244.GL3839@shale.localdomain>
Hi Dan,
* Dan Carpenter <error27@gmail.com> [2011-08-03 17:22:45 +0300]:
> There was a small typo here so we never actually hit the goto which
> would call hci_dev_unlock_bh().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index baaf5eb..56943ad 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -1326,7 +1326,7 @@ int hci_blacklist_add(struct hci_dev *hdev, bdaddr_t *bdaddr)
>
> entry = kzalloc(sizeof(struct bdaddr_list), GFP_KERNEL);
> if (!entry) {
> - return -ENOMEM;
> + err = -ENOMEM;
> goto err;
> }
Patch has been applied, thanks.
Gustavo
prev parent reply other threads:[~2011-08-11 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 14:22 [patch] bluetooth: unlock if allocation fails in hci_blacklist_add() Dan Carpenter
2011-08-11 19:35 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811193533.GB19699@joana \
--to=padovan@profusion.mobi \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox