From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Date: Thu, 11 Aug 2011 19:35:34 +0000 Subject: Re: [patch] bluetooth: unlock if allocation fails in Message-Id: <20110811193533.GB19699@joana> List-Id: References: <20110803142244.GL3839@shale.localdomain> In-Reply-To: <20110803142244.GL3839@shale.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Marcel Holtmann , "open list:BLUETOOTH SUBSYSTEM" , kernel-janitors@vger.kernel.org Hi Dan, * Dan Carpenter [2011-08-03 17:22:45 +0300]: > There was a small typo here so we never actually hit the goto which > would call hci_dev_unlock_bh(). > > Signed-off-by: Dan Carpenter > > diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c > index baaf5eb..56943ad 100644 > --- a/net/bluetooth/hci_core.c > +++ b/net/bluetooth/hci_core.c > @@ -1326,7 +1326,7 @@ int hci_blacklist_add(struct hci_dev *hdev, bdaddr_t *bdaddr) > > entry = kzalloc(sizeof(struct bdaddr_list), GFP_KERNEL); > if (!entry) { > - return -ENOMEM; > + err = -ENOMEM; > goto err; > } Patch has been applied, thanks. Gustavo