* [patch] bluetooth: unlock if allocation fails in hci_blacklist_add()
@ 2011-08-03 14:22 Dan Carpenter
2011-08-11 19:35 ` [patch] bluetooth: unlock if allocation fails in Gustavo Padovan
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-08-03 14:22 UTC (permalink / raw)
To: Gustavo F. Padovan
Cc: Marcel Holtmann, open list:BLUETOOTH SUBSYSTEM, kernel-janitors
There was a small typo here so we never actually hit the goto which
would call hci_dev_unlock_bh().
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index baaf5eb..56943ad 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -1326,7 +1326,7 @@ int hci_blacklist_add(struct hci_dev *hdev, bdaddr_t *bdaddr)
entry = kzalloc(sizeof(struct bdaddr_list), GFP_KERNEL);
if (!entry) {
- return -ENOMEM;
+ err = -ENOMEM;
goto err;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] bluetooth: unlock if allocation fails in
2011-08-03 14:22 [patch] bluetooth: unlock if allocation fails in hci_blacklist_add() Dan Carpenter
@ 2011-08-11 19:35 ` Gustavo Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo Padovan @ 2011-08-11 19:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: Marcel Holtmann, open list:BLUETOOTH SUBSYSTEM, kernel-janitors
Hi Dan,
* Dan Carpenter <error27@gmail.com> [2011-08-03 17:22:45 +0300]:
> There was a small typo here so we never actually hit the goto which
> would call hci_dev_unlock_bh().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index baaf5eb..56943ad 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -1326,7 +1326,7 @@ int hci_blacklist_add(struct hci_dev *hdev, bdaddr_t *bdaddr)
>
> entry = kzalloc(sizeof(struct bdaddr_list), GFP_KERNEL);
> if (!entry) {
> - return -ENOMEM;
> + err = -ENOMEM;
> goto err;
> }
Patch has been applied, thanks.
Gustavo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-11 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-03 14:22 [patch] bluetooth: unlock if allocation fails in hci_blacklist_add() Dan Carpenter
2011-08-11 19:35 ` [patch] bluetooth: unlock if allocation fails in Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox