From: Dan Carpenter <error27@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "open list:BROADCOM SPECIFIC..." <linux-wireless@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] bcma: signedness bug in bcma_get_next_core()
Date: Wed, 24 Aug 2011 10:17:07 +0000 [thread overview]
Message-ID: <20110824101707.GA5975@shale.localdomain> (raw)
In-Reply-To: <CACna6rwLrGa4LU2GOQ03w+t5FfrD+c1rdHki_Nu-3oPVninCJg@mail.gmail.com>
On Wed, Aug 24, 2011 at 12:01:11PM +0200, Rafał Miłecki wrote:
> Dan, I asked you to use int in both: call and function declaration.
> I'm the author of that code, and I don't have anything against
> modifying that :)
>
> I think int is used much more often that s32 for errors.
>
No problem. Should I make bcma_erom_get_mst_port() return 0 on
success while I'm at it?
regards,
dan carpenter
next prev parent reply other threads:[~2011-08-24 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 13:38 [patch -next] bcma: signedness bug in bcma_get_next_core() Dan Carpenter
2011-08-20 12:23 ` Rafał Miłecki
2011-08-20 12:59 ` walter harms
2011-08-20 13:31 ` Rafał Miłecki
2011-08-23 19:13 ` Dan Carpenter
2011-08-24 10:01 ` Rafał Miłecki
2011-08-24 10:17 ` Dan Carpenter [this message]
2011-08-23 19:15 ` [patch -next v2] " Dan Carpenter
2011-08-20 14:11 ` [patch -next] " walter harms
2011-08-20 14:17 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824101707.GA5975@shale.localdomain \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox