From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] agp: potential info leak in compat_agpioc_info_wrap()
Date: Fri, 23 Sep 2011 07:30:04 +0000 [thread overview]
Message-ID: <20110923073004.GE29426@longonot.mountain> (raw)
In-Reply-To: <1316761455.2560.15.camel@edumazet-laptop>
On Fri, Sep 23, 2011 at 09:04:15AM +0200, Eric Dumazet wrote:
> > The agp_info32 struct has a 4 byte hole in it so we need to clear
> > that before copying it to userspace.
> >
> > struct agp_info32 {
> > struct agp_version version; /* 0 0 */
> >
> > /* XXX 4 bytes hole, try to pack */
> >
>
> This makes no sense :
>
> Why should we have a 32bit hole before an u32 field ?
>
Crap. You're right. It saw the agp_version struct as a hole.
Sorry for the noise.
regards,
dan carpenter
prev parent reply other threads:[~2011-09-23 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 6:19 [patch] agp: potential info leak in compat_agpioc_info_wrap() Dan Carpenter
2011-09-23 7:04 ` Eric Dumazet
2011-09-23 7:30 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110923073004.GE29426@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=eric.dumazet@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox