* [patch] xen: double lock typo
@ 2011-09-27 7:07 Dan Carpenter
2011-09-27 22:17 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-09-27 7:07 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: kernel-janitors, xen-devel, virtualization, Jan Beulich,
Konrad Rzeszutek Wilk
We called mutex_lock() twice instead of unlocking.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/xen/xen-pciback/vpci.c b/drivers/xen/xen-pciback/vpci.c
index 01222d7..46d140b 100644
--- a/drivers/xen/xen-pciback/vpci.c
+++ b/drivers/xen/xen-pciback/vpci.c
@@ -238,7 +238,7 @@ static int __xen_pcibk_get_pcifront_dev(struct pci_dev *pcidev,
}
}
}
- mutex_lock(&vpci_dev->lock);
+ mutex_unlock(&vpci_dev->lock);
return found;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] xen: double lock typo
2011-09-27 7:07 [patch] xen: double lock typo Dan Carpenter
@ 2011-09-27 22:17 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Rzeszutek Wilk @ 2011-09-27 22:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jeremy Fitzhardinge, kernel-janitors, xen-devel, Jan Beulich,
virtualization
On Tue, Sep 27, 2011 at 10:07:21AM +0300, Dan Carpenter wrote:
> We called mutex_lock() twice instead of unlocking.
Duh. OK, queued up.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/xen/xen-pciback/vpci.c b/drivers/xen/xen-pciback/vpci.c
> index 01222d7..46d140b 100644
> --- a/drivers/xen/xen-pciback/vpci.c
> +++ b/drivers/xen/xen-pciback/vpci.c
> @@ -238,7 +238,7 @@ static int __xen_pcibk_get_pcifront_dev(struct pci_dev *pcidev,
> }
> }
> }
> - mutex_lock(&vpci_dev->lock);
> + mutex_unlock(&vpci_dev->lock);
> return found;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-27 22:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-27 7:07 [patch] xen: double lock typo Dan Carpenter
2011-09-27 22:17 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox