From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
kernel-janitors@vger.kernel.org, xen-devel@lists.xensource.com,
Jan Beulich <jbeulich@suse.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [patch] xen: double lock typo
Date: Tue, 27 Sep 2011 22:17:39 +0000 [thread overview]
Message-ID: <20110927221739.GC10820@phenom.oracle.com> (raw)
In-Reply-To: <20110927070721.GA7351@elgon.mountain>
On Tue, Sep 27, 2011 at 10:07:21AM +0300, Dan Carpenter wrote:
> We called mutex_lock() twice instead of unlocking.
Duh. OK, queued up.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/xen/xen-pciback/vpci.c b/drivers/xen/xen-pciback/vpci.c
> index 01222d7..46d140b 100644
> --- a/drivers/xen/xen-pciback/vpci.c
> +++ b/drivers/xen/xen-pciback/vpci.c
> @@ -238,7 +238,7 @@ static int __xen_pcibk_get_pcifront_dev(struct pci_dev *pcidev,
> }
> }
> }
> - mutex_lock(&vpci_dev->lock);
> + mutex_unlock(&vpci_dev->lock);
> return found;
> }
>
prev parent reply other threads:[~2011-09-27 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 7:07 [patch] xen: double lock typo Dan Carpenter
2011-09-27 22:17 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110927221739.GC10820@phenom.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=jbeulich@suse.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox