From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: Adaptec OEM Raid Solutions <aacraid@adaptec.com>,
"James E.J. Bottomley" <jbottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] [SCSI] aacraid: use lower snprintf() limit
Date: Thu, 06 Oct 2011 14:27:58 +0000 [thread overview]
Message-ID: <20111006142758.GB18470@longonot.mountain> (raw)
In-Reply-To: <d97a34694e741dc6a2a71fbcd49bab49.squirrel@webmail.sf-mail.de>
On Wed, Oct 05, 2011 at 09:35:13AM +0200, Rolf Eike Beer wrote:
> > dev->supplement_adapter_info.MfgPcbaSerialNo);
> > +
> > +
>
> One newline too much.
>
True. I wish checkpatch.pl checked for that...
> > + if (len > 16)
> > + len = 16;
>
> max()?
min() actually. I don't know that it improves the readability, but
can do.
regards,
dan carpenter
next prev parent reply other threads:[~2011-10-06 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 5:50 [patch] [SCSI] aacraid: use lower snprintf() limit Dan Carpenter
2011-10-05 7:35 ` Rolf Eike Beer
2011-10-05 12:19 ` Achim Leubner
2011-10-06 14:30 ` Dan Carpenter
2011-10-11 14:46 ` Achim Leubner
2011-10-06 14:27 ` Dan Carpenter [this message]
2011-10-08 10:45 ` [patch v2] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006142758.GB18470@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=aacraid@adaptec.com \
--cc=eike-kernel@sf-tec.de \
--cc=jbottomley@parallels.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox