Re: [patch] [SCSI] aacraid: use lower snprintf() limit

Dan Carpenter
2011-10-06T14:27:58Z

On Wed, Oct 05, 2011 at 09:35:13AM +0200, Rolf Eike Beer wrote:
> > dev->supplement_adapter_info.MfgPcbaSerialNo);
> > +
> > +
>
> One newline too much.
>

True. I wish checkpatch.pl checked for that...

> > + if (len > 16)
> > + len = 16;
>
> max()?

min() actually. I don't know that it improves the readability, but
can do.

regards,
dan carpenter