From: Marcelo Tosatti <mtosatti@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] KVM: make checks stricter in coalesced_mmio_in_range()
Date: Wed, 19 Oct 2011 17:26:24 +0000 [thread overview]
Message-ID: <20111019172624.GB8575@amt.cnet> (raw)
In-Reply-To: <20111019061510.GA12399@elgon.mountain>
On Wed, Oct 19, 2011 at 09:15:10AM +0300, Dan Carpenter wrote:
> My testing version of Smatch complains that addr and len come from
> the user and they can wrap. The path is:
> -> kvm_vm_ioctl()
> -> kvm_vm_ioctl_unregister_coalesced_mmio()
> -> coalesced_mmio_in_range()
>
> I don't know what the implications are of wrapping here, but we may
> as well fix it, if only to silence the warning.
There are no negative implications, if variables wrap unregistration
fails. Applied, thanks.
prev parent reply other threads:[~2011-10-19 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 6:15 [patch] KVM: make checks stricter in coalesced_mmio_in_range() Dan Carpenter
2011-10-19 17:26 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019172624.GB8575@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox