From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3.0]isdn add audit to request_region
Date: Tue, 25 Oct 2011 09:22:36 +0000 [thread overview]
Message-ID: <20111025092236.GB9887@mwanda> (raw)
In-Reply-To: <CAAgJb5vScDn0j4aTr498OWGr31bjGwLofyfaaAXzshXf8O68_Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Tue, Oct 25, 2011 at 04:18:47PM +0800, Jimmy Pan wrote:
> Add three audit for request_region() function.
> Mere newbie here, I don't know if my style of posting and developing is correct.
> If anything I've done wrong, please correct me.
>
This patch doesn't really do anything worthwhile. It just adds some
debugging output that no one will ever see. If you really need this,
then can you explain why?
Other details:
1) The patch doesn't apply. Your email client line wrapped.
Read Documentation/email-clients.txt Send the patch to yourself.
Save the raw email (including headers). cat raw_email.txt | patch -p1
2) You need to add a Signed-off-by line.
3) CC the right maintainers. Use the ./scripts/get_maintainer.pl
Add kernel-janitors as a CC and we can give you any hints.
Don't worry that your first patch was not accepted. Everyone starts
as a newbie. Welcome. :)
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-10-25 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 8:18 [PATCH 3.0]isdn add audit to request_region Jimmy Pan
2011-10-25 9:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111025092236.GB9887@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox