public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Takashi Iwai <tiwai@suse.de>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [ALSA] hwdep: silence integer overflow warning
Date: Fri, 28 Oct 2011 06:45:25 +0000	[thread overview]
Message-ID: <20111028064525.GA14707@longonot.mountain> (raw)
In-Reply-To: <4E9FD02B.6030307@bfs.de>

On Thu, Oct 20, 2011 at 09:39:23AM +0200, walter harms wrote:
> I am not sure how SNDRV_MINOR_HWDEPS is used further

Either device = SNDRV_MINOR_HWDEPS or device = SNDRV_MINOR_HWDEPS + 1
are fine (equivalent) but it's a fair point.  Your version is nicer.

I'll redo the patch.

regards,
dan carpenter


  reply	other threads:[~2011-10-28  6:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20  6:09 [patch] [ALSA] hwdep: silence integer overflow warning Dan Carpenter
2011-10-20  7:39 ` walter harms
2011-10-28  6:45   ` Dan Carpenter [this message]
2011-10-28  7:33     ` walter harms
2011-10-28  8:55       ` Dan Carpenter
2011-10-28  6:46   ` [patch v2] " Dan Carpenter
2011-10-31  8:55     ` [alsa-devel] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111028064525.GA14707@longonot.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tiwai@suse.de \
    --cc=wharms@bfs.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox