From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 28 Oct 2011 08:55:20 +0000 Subject: Re: [patch] [ALSA] hwdep: silence integer overflow warning Message-Id: <20111028085520.GB14900@longonot.mountain> List-Id: References: <20111020060910.GA6101@elgon.mountain> <4E9FD02B.6030307@bfs.de> <20111028064525.GA14707@longonot.mountain> <4EAA5AB7.9000903@bfs.de> In-Reply-To: <4EAA5AB7.9000903@bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: walter harms Cc: Takashi Iwai , Paul Gortmaker , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org On Fri, Oct 28, 2011 at 09:33:11AM +0200, walter harms wrote: > > > Am 28.10.2011 08:45, schrieb Dan Carpenter: > > On Thu, Oct 20, 2011 at 09:39:23AM +0200, walter harms wrote: > >> I am not sure how SNDRV_MINOR_HWDEPS is used further > > > > Either device = SNDRV_MINOR_HWDEPS or device = SNDRV_MINOR_HWDEPS + 1 > > are fine (equivalent) but it's a fair point. Your version is nicer. > > > > I'll redo the patch. > > > > An other question is: > Should the user be informed that the device is modified ? > The Problem i see is that a user parameter is silently modified > and buggy code will come through. That would be an API change. This is cut and pasted code, and we've had this exact discussion before for sound/core/rawmidi.c a year ago. You were involved in the discussion too. :P http://marc.info/?l=kernel-janitors&m8401699203676&w=2 regards, dan carpenter