Re: [PATCH 1/4] drivers/staging/vt6656/wpa2.h: Removed ttype.h and

[Dan Carpenter <dan.carpenter@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]

On Fri, Nov 04, 2011 at 07:09:07AM -0300, Marcos Souza wrote:
> So, I forgot to include kernels janitors on theses patches, so, forwarding...
> 

These should go to what the get_maintainer.pl script says.

./scripts/get_maintainer.pl -f drivers/staging/vt6656/wpa2.h

Don't include linux-kernel though, they don't care about white space
fixes.

Why are you removing the "ttype.h" include?  I'm not saying you're
wrong to do that, but you should explain that in the change log.  Is
the ttype.h file not needed anymore or something?

Also don't put "So, I forgot to include kernels janitors on theses
patches, so, forwarding..." in the changelog part of the email.  How
maintainers apply patches is that they save the raw text of the email
and then cat raw_email.txt | git am.  Those kind of comments should
go after the --- and before the diff where I've marked below.  git am
ignores the stuff there.

> Removed some old comments and removed ttype.h of the file.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com>
> ---
  ^^^
Put extra comments here, below those three dashes.

>  typedef struct tagsPMKIDInfo {
> -    BYTE    abyBSSID[6];
> -    BYTE    abyPMKID[16];
> +	unsigned char abyBSSID[6];
> +	unsigned char abyPMKID[16];

It's not a big deal either way, but normally people would use "u8"
here.

regards,
dan carpenter



[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]