Re: [PATCH 3/4] drivers/staging/vt6656/iocmd.h: Removed ttype.h and

[Dan Carpenter <dan.carpenter@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]

This patch was mangled by your mail client.  Read
Documentation/email-clients.txt, send the patch to yourself.  Verify
that it applies and then resend.

On Fri, Nov 04, 2011 at 07:10:56AM -0300, Marcos Souza wrote:
> I forgot to sent these patches, so I'm sending now
> 
> Removed comments about functions/veriables static and stuff like these.
                                   variables
Normally, we don't comment too much on changelog spelling but since
you're going to resend this anyway, could you fix the typo there?



> @@ -123,18 +115,16 @@ typedef struct tagSCmdBSSJoin {
>      u16     wBBPType;
>      u8	    ssid[SSID_MAXLEN + 2];
>      u32	    uChannel;
> -    BOOL    bPSEnable;
> -    BOOL    bShareKeyAuth;
> +    int    bPSEnable;
> +    int    bShareKeyAuth;

These should be bool.  Obviously in the original code, BOOL was
defined as int and changing it has the potential to break things so
it needs care.  You would need to look at all the places where
bPSEnable is used and verify that it works for type "bool".  Use grep
or cscope.  If you don't feel comfortable doing that, then I would
leave it as is for now.

> - BOOL       bWrite;
> + int       bWrite;

Same thing for all the other places as well.

Some people might complain that this patch does too many things in
a single patch.  Maybe break out the white space changes from the
other changes.

regards,
dan carpenter

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]