Fwd: [PATCH 2/4] drivers/staging/vt6656/upc.h: Remove ttype.h and

Fwd: [PATCH 2/4] drivers/staging/vt6656/upc.h: Remove ttype.h and

[Marcos Souza]

I forgot to sent these patches to the janitors...

Removed ttype.h for TODO file, and removed some odd comments

Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com>
---
 drivers/staging/vt6656/upc.h |   38 ++++++++++----------------------------
 1 files changed, 10 insertions(+), 28 deletions(-)

diff --git a/drivers/staging/vt6656/upc.h b/drivers/staging/vt6656/upc.h
index b33aba4..67eaf13 100644
--- a/drivers/staging/vt6656/upc.h
+++ b/drivers/staging/vt6656/upc.h
@@ -30,14 +30,8 @@
 #define __UPC_H__

 #include "device.h"
-#include "ttype.h"

-/*---------------------  Export Definitions -------------------------*/
-
-
-//
-//  For IO mapped
-//
+/*  For IO mapped */

 #ifdef IO_MAP

@@ -70,13 +64,10 @@

 #else

-//
-//  For memory mapped IO
-//
-
+/* For memory mapped IO */

 #define VNSvInPortB(dwIOAddress, pbyData) {                     \
-	volatile BYTE* pbyAddr = ((PBYTE)(dwIOAddress));            \
+	volatile unsigned char* pbyAddr = ((unsigned char *)(dwIOAddress)); \
 	*(pbyData) = readb(pbyAddr);                           \
 }

@@ -87,14 +78,14 @@
 }

 #define VNSvInPortD(dwIOAddress, pdwData) {                     \
-	volatile DWORD* pdwAddr = ((PDWORD)(dwIOAddress));          \
+	volatile unsigned long* pdwAddr = ((unsigned long *)(dwIOAddress));          \
 	*(pdwData) = readl(pdwAddr);                           \
 }


 #define VNSvOutPortB(dwIOAddress, byData) {                     \
-    volatile BYTE* pbyAddr = ((PBYTE)(dwIOAddress));            \
-    writeb((BYTE)byData, pbyAddr);							\
+	volatile unsigned char* pbyAddr = ((unsigned char *)(dwIOAddress));
          \
+	writeb((unsigned char)byData, pbyAddr);							\
 }


@@ -104,16 +95,14 @@
 }

 #define VNSvOutPortD(dwIOAddress, dwData) {                     \
-    volatile DWORD* pdwAddr = ((PDWORD)(dwIOAddress));          \
-    writel((DWORD)dwData, pdwAddr);					    \
+	volatile unsigned long* pdwAddr = ((unsigned long *)(dwIOAddress));          \
+	writel((unsigned long)dwData, pdwAddr);					    \
 }

 #endif

+/*ALWAYS IO-Mapped IO when in 16-bit/32-bit environment */

-//
-// ALWAYS IO-Mapped IO when in 16-bit/32-bit environment
-//
 #define PCBvInPortB(dwIOAddress, pbyData) {     \
 	    *(pbyData) = inb(dwIOAddress);          \
 }
@@ -140,7 +129,7 @@


 #define PCAvDelayByIO(uDelayUnit) {             \
-    BYTE    byData;                             \
+	unsigned char    byData;                             \
     unsigned long   ii;                                 \
                                                 \
     if (uDelayUnit <= 50) {                     \
@@ -152,11 +141,4 @@
     }                                           \
 }

-
-/*---------------------  Export Classes  ----------------------------*/
-
-/*---------------------  Export Variables  --------------------------*/
-
-/*---------------------  Export Functions  --------------------------*/
-
 #endif /* __UPC_H__ */
-- 
1.7.4.4




-- 
Marcos Paulo de Souza

*Porque uma vida sem desafios é uma vida sem razão.*
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Fwd: [PATCH 2/4] drivers/staging/vt6656/upc.h: Remove ttype.h

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

This doesn't apply to my copy of linux-next.  But that could be my
fault.  I'm not at my normal network right now, and my copy of
linux-next is two weeks old on this computer.  All patches should be
written against linux-next.

http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=summary

If you already wrote it against the latest linux-next then ignore me
and keep up the good work etc.  :)

regards,
dan carpenter

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: Fwd: [PATCH 2/4] drivers/staging/vt6656/upc.h: Remove ttype.h and

[Marcos Souza]

2011/11/4, Dan Carpenter <dan.carpenter@oracle.com>:
> This doesn't apply to my copy of linux-next.  But that could be my
> fault.  I'm not at my normal network right now, and my copy of
> linux-next is two weeks old on this computer.  All patches should be
> written against linux-next.
>
> http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=summary
>
> If you already wrote it against the latest linux-next then ignore me
> and keep up the good work etc.  :)
Once, I cloned the linux-next tree. But after one day, my git pull
gives a lot of errors(on that time I don't knew half that I know now
about the kernel...).

I made this against the current Linus tree.

I will wait the Greg's comments too, and will try to use the linux-next..
>
> regards,
> dan carpenter
>
See ya,

-- 
Marcos Paulo de Souza

*Porque uma vida sem desafios é uma vida sem razão.*
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Fwd: [PATCH 2/4] drivers/staging/vt6656/upc.h: Remove ttype.h

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 2024 bytes --]

On Fri, Nov 04, 2011 at 08:40:30AM -0300, Marcos Souza wrote:
> 2011/11/4, Dan Carpenter <dan.carpenter@oracle.com>:
> > This doesn't apply to my copy of linux-next.  But that could be my
> > fault.  I'm not at my normal network right now, and my copy of
> > linux-next is two weeks old on this computer.  All patches should be
> > written against linux-next.
> >
> > http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=summary
> >
> > If you already wrote it against the latest linux-next then ignore me
> > and keep up the good work etc.  :)
> Once, I cloned the linux-next tree. But after one day, my git pull
                                                            ^^^^^^^^
> gives a lot of errors(on that time I don't knew half that I know now
> about the kernel...).
> 

Don't do a git pull of linux-next.  A git pull is short for:
git fetch git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git merge FETCH_HEAD

The way to use linux-next is first do a fetch then a checkout:
git fetch git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git checkout FETCH_HEAD

Longer explanation:

Normally in version control the whole point is to keep the history,
but for linux-next we redo it every day.  So you can't merge today's
history with yesterdays history.  You just take whatever is in
linux-next for today.

So let's say you are Linus and you apply a patch that later on turns
out to be a mistake.  The only thing he can do is apply another
patch on top of the first patch to fix the problem.  Maintainer trees
are more flexible if they find a mistake then they just edit the git
history so it looks like that patch was never applied.  We rebuild
linux next from scratch using the maintainer trees every day and
everyone is happy.  But once the patch hit Linus's tree it's set in
stone and you can't edit the git history anymore.

It's because we edit the history in linux-next that your pull failed.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]