public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/vt6656/iwctl.c: Remove PRINT_K macro
Date: Mon, 07 Nov 2011 05:43:06 +0000	[thread overview]
Message-ID: <20111107054306.GU4682@mwanda> (raw)
In-Reply-To: <1320634885-5845-1-git-send-email-marcos.mage@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

Hi Marcos,

This should be sent to devel@driverdev.osuosl.org as well.

DBG_PRT() is just as bad as PRINT_K().  The first example in
iwctl_siwscan() should be either pr_debug() or dev_dbg().  Also the
message itself is wrong.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-11-07  5:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07  3:01 [PATCH] drivers/staging/vt6656/iwctl.c: Remove PRINT_K macro Marcos Paulo de Souza
2011-11-07  5:43 ` Dan Carpenter [this message]
2011-11-07 10:27 ` Marcos Souza
2011-11-07 10:47 ` Dan Carpenter
2011-11-07 11:52 ` Marcos Souza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111107054306.GU4682@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox